Conversation
* Use pycolmap.Reconstruction instead of SceneManager * Use CameraModelId instead of string comparison
johnvanatta-plus
left a comment
There was a problem hiding this comment.
I don't think I can review this--I'm not part of the gsplat team, so I don't know what they plan for on Colmap version compatibility. I've used this patch for my own project and it works well. Sorry :)
Co-authored-by: Rogério Gasi <rtgasi@gmail.com>
|
Hi @npu-chenlin . |
Thanks for your suggestion, but we have already corrected the parameter index in our code. Could it be that you are using an earlier commit? |
|
Ah I'm sorry I was using the old version. I noticed the bug was already fixed. Thank you! @npu-chenlin |
|
Thanks @npu-chenlin This PR allows |
Use pycolmap.Reconstruction instead of SceneManager
Use CameraModelId instead of string comparison