Create minimal pyproject.toml file#581
Open
kleinicke wants to merge 1 commit intonerfstudio-project:mainfrom
Open
Create minimal pyproject.toml file#581kleinicke wants to merge 1 commit intonerfstudio-project:mainfrom
kleinicke wants to merge 1 commit intonerfstudio-project:mainfrom
Conversation
Allow building with a pip version newer than 23.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow building with a pip version newer than pip 23.1.
To test if this commit helps, you can run successfully with a new environment
pip install git+https://github.com/kleinicke/gsplat@8b5dfa8fbd996be21738e635291e94c940514a1aWhile
pip install git+https://github.com/nerfstudio-project/gsplat.gitcauses an torch not installed error when torch is not installed and for a pip version 23.1 and newer, even when torch is installed.
This issue was described in #363 and a possible fix was proposed in #364, but it added more unnecessary changes.