-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize MCMC strategy and some tiny fix #3548
Conversation
tried to use this but got a |
Yes this might happen since MCMC uses a fixed number of gs for the scene. Could you please try add |
Even setting to 500,000 leads to a OOM error sadly (I'm using a 3060), I had to reduce to 100,000 gaussian. That seems like too few(?) but I honestly don't know. I'll do some more testing |
I'm also getting OOM errors here with |
It's possible there are some memory differences between gsplat and nerfstudio because of dataloader overhead. When you run gsplat is the memory usage very close to 24GB? it may help to make sure the images are cached on CPU inside splatfacto-mcmc (there's a FullImagesDataManager parameter for this). If splatfacto-mcmc is taking significantly more memory than gsplat's version that would be surprising, but I think a difference of ~1GB is expected. MCMC in general will take more memory than the default strategy since the re-sampling step is a little memory hungry. |
I've observed the OOM issue using Gsplat directly through What is this PR missing at this point in order to get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me now!
Not getting OOM errors anymore since updating to latest version! However I am also getting these huge floaters / haze which cover the entire model in every MCMC scene, which I also had when using MCMC in gsplat. Unfortunately they are extremely difficult to cleanup in post, as they only show up from certain camera positions and are miles away from the main scene. Here is a video showing the issue: https://www.youtube.com/watch?v=lnjtVM_oRtA |
This is great! Thank you for all the work getting this integrated. I am also seeing the huge floaters/haze in the MCMC scene. Is there a plan to get this fixed anytime soon? |
To remove the huge splats, a quick (and probably dirty) workaround is to filter them here by adding large splats to the |
Finalize MCMC strategy #3436, fix bilagird lr rate for splatfacto-big #3383 and some small changes to colmap dataparser (auto iterates possible colmap paths).
Tested on bicycle with random/sfm initialization.
To use:
ns-train splatfacto-mcmc