Skip to content

feat: refactor dao_event#2378

Merged
zmcNotafraid merged 6 commits intonervosnetwork:developfrom
zmcNotafraid:issue-297-2
Jan 2, 2025
Merged

feat: refactor dao_event#2378
zmcNotafraid merged 6 commits intonervosnetwork:developfrom
zmcNotafraid:issue-297-2

Conversation

@zmcNotafraid
Copy link
Contributor

No description provided.

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@zmcNotafraid zmcNotafraid marked this pull request as draft December 31, 2024 02:42
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 54.79452% with 33 lines in your changes missing coverage. Please review.

Project coverage is 55.32%. Comparing base (f373f6b) to head (e104de1).
Report is 579 commits behind head on develop.

Files with missing lines Patch % Lines
.../tasks/migration/fill_cell_index_to_dao_event.rake 0.00% 17 Missing ⚠️
lib/tasks/migration/check_dao_event.rake 16.66% 15 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 95.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (e104de1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (e104de1)
2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2378       +/-   ##
============================================
- Coverage    67.56%   55.32%   -12.24%     
============================================
  Files          289      374       +85     
  Lines         7944    10756     +2812     
============================================
+ Hits          5367     5951      +584     
- Misses        2577     4805     +2228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@zmcNotafraid zmcNotafraid marked this pull request as ready for review December 31, 2024 11:52
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Jan 2, 2025
Merged via the queue into nervosnetwork:develop with commit 57ef816 Jan 2, 2025
@zmcNotafraid zmcNotafraid deleted the issue-297-2 branch January 2, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants