Skip to content

fix group by transaction#240

Merged
quake merged 3 commits intodevelopfrom
fix-group-by-transaction
Sep 2, 2025
Merged

fix group by transaction#240
quake merged 3 commits intodevelopfrom
fix-group-by-transaction

Conversation

@Officeyutong
Copy link
Collaborator

@Officeyutong Officeyutong commented Sep 1, 2025

There is a bug in the new implementation of group_by_transaction which may split a tx into two parts in the return value. This PR fixes it by reverting it to the previous implementation.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.80%. Comparing base (0685266) to head (bb393fb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #240   +/-   ##
========================================
  Coverage    71.80%   71.80%           
========================================
  Files           27       27           
  Lines         6942     6942           
========================================
  Hits          4985     4985           
  Misses        1957     1957           
Flag Coverage Δ
unittests 71.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Officeyutong Officeyutong marked this pull request as draft September 2, 2025 04:43
@Officeyutong Officeyutong marked this pull request as ready for review September 2, 2025 10:50
@quake quake merged commit b46d685 into develop Sep 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants