Skip to content

db: support sqlite on native platforms#267

Closed
Officeyutong wants to merge 9 commits intonervosnetwork:developfrom
Officeyutong:support-sqlite
Closed

db: support sqlite on native platforms#267
Officeyutong wants to merge 9 commits intonervosnetwork:developfrom
Officeyutong:support-sqlite

Conversation

@Officeyutong
Copy link
Collaborator

This PR implementes sqlite as a database backend of ckb-light-client. This will be used for light-client on Android.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 95.51761% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.82%. Comparing base (0cff318) to head (3403b47).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
light-client-lib/src/storage/db/mod.rs 93.53% 32 Missing ⚠️
light-client-lib/src/storage/db/native_rocksdb.rs 97.73% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #267      +/-   ##
===========================================
+ Coverage    72.00%   73.82%   +1.81%     
===========================================
  Files           28       29       +1     
  Lines         7040     6429     -611     
===========================================
- Hits          5069     4746     -323     
+ Misses        1971     1683     -288     
Flag Coverage Δ
unittests 73.82% <95.51%> (+1.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Officeyutong Officeyutong marked this pull request as ready for review January 8, 2026 14:07

#[rpc(server)]
pub trait BlockFilterRpc {
/// curl http://localhost:9000/ -X POST -H "Content-Type: application/json" -d '{"jsonrpc": "2.0", "method":"set_scripts", "params": [{"script": {"code_hash": "0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8", "hash_type": "type", "args": "0x50878ce52a68feb47237c29574d82288f58b5d21"}, "block_number": "0x59F74D"}], "id": 1}'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we have this comment here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, it's here since the original implementation, so I keep it

@quake
Copy link
Member

quake commented Feb 24, 2026

duplicate: #270

@quake quake closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants