storage: use trait for some high level storage operations & merge RPC operations of native and wasm#268
Closed
Officeyutong wants to merge 20 commits intonervosnetwork:developfrom
Closed
Conversation
Officeyutong
changed the title
eval-exec
approved these changes
Feb 9, 2026
Member
|
duplicate #270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following traits:
get_pinnedfunction ofstruct Storagestruct Batchof each database implementationsWith these traits,
StorageWithChainDataandXXXRPCImpls won't base onstruct Storage, instead, they will be based on the given traits.Based on these traits, this PR merges ths PRC implementations of
rocksdb,rusqliteandwasminto a single crateckb-light-client-rpc, without the need of three duplicated RPC implementations