Add new macros to allow assertions with custom exit code#131
Merged
mohanson merged 5 commits intonervosnetwork:masterfrom Mar 12, 2025
Merged
Add new macros to allow assertions with custom exit code#131mohanson merged 5 commits intonervosnetwork:masterfrom
mohanson merged 5 commits intonervosnetwork:masterfrom
Conversation
XuJiandong
reviewed
Mar 5, 2025
src/asserts.rs
Outdated
| }}; | ||
| } | ||
|
|
||
| pub fn set_error_expect<C: Into<i8>, T, E: Debug>(c: C, r: Result<T, E>, msg: &str) -> T { |
Collaborator
There was a problem hiding this comment.
It's better to add following:
- Option's expect
- macro assert_ne!
- Result's expect_err
Collaborator
It's better to keep Rust's conventions |
Collaborator
Author
If you look at it, |
mohanson
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds 2 new macros & 1 utility functions, that allows one to set the return error code first, then runs assertions in Rust.
This allows us to get the benefit of both worlds: we could use assertion lines with decent debug message outputs, while at the same time we can also customize final exit code.