fix(x64-simulator): use actual_index for outputs_data in SOURCE_GROUP_OUTPUT#46
Merged
quake merged 2 commits intonervosnetwork:mainfrom Jan 27, 2026
Merged
fix(x64-simulator): use actual_index for outputs_data in SOURCE_GROUP_OUTPUT#46quake merged 2 commits intonervosnetwork:mainfrom
quake merged 2 commits intonervosnetwork:mainfrom
Conversation
…_OUTPUT Fix incorrect cell data fetching when using Source::GroupOutput. The code was using the group-relative index instead of the transaction-relative actual_index to retrieve outputs_data, causing wrong cell data to be returned when the type script only appears on a subset of outputs.
quake
requested review from
XuJiandong,
Copilot and
mohanson
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect cell data fetching when using Source::GroupOutput. The code
was using the group-relative index instead of the transaction-relative
actual_index to retrieve outputs_data, causing wrong cell data to be
returned when the type script only appears on a subset of outputs.