perf: Optimize NEXT_INST macro by reordering memory loads for better performance#465
Merged
quake merged 1 commit intonervosnetwork:developfrom Mar 14, 2025
Merged
Conversation
xxuejie
approved these changes
Mar 12, 2025
Collaborator
xxuejie
left a comment
There was a problem hiding this comment.
I remembered the code was written as the changes after this PR in the first place. Later in profiling, it was revealed that memory load from INST_ARGS and INST_PC cause enough cache misses, so the instructions are shuffled. Not sure if it is a good idea to move those instructions back again. I can only confirm that the correctness of the code has no issues.
Collaborator
|
Confirmed that the performance has been significantly improved. |
mohanson
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple instruction reordering in the NEXT_INST macro may reduce memory access latency and improve instruction-level parallelism. This change improves performance by approximately 2% on my env (2 diferenet spec cpu) because of hot path.
CPU1
CPU2