refactor: Add a new trait between AsmMachine and Box<AsmCoreMachine>#473
Merged
xxuejie merged 1 commit intonervosnetwork:developfrom Mar 27, 2025
Merged
Conversation
In current design, AsmMachine is a rigid type containing Box<AsmCoreMachine> directly. This is required in a sense that assembly VM needs to know the inner data structures of AsmCoreMachine so as to function. However, It also puts a restriction on AsmMachine: while you can do the following in Rust VM: ``` DefaultMachine<Foo<DefaultCoreMachine<...>> ``` as long as Foo implements SupportMachine via a newtype pattern, this is not possible on AsmMachine. However there are certain cases we need wrappers on `Box<AsmCoreMachine>` to customize behaviors. This commit introduces a a new trait `AsmCoreMachineRevealer` between AsmMachine and AsmCoreMachine, it provides a mean for users of AsmMachine to customize its behavior, while also requires the presence of AsmCoreMachine, so assembly VM can still function. If only Rust has generic specialization, we won't need to go through all those troubles...
mohanson
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #472 cherry-picked to develop branch.
In current design, AsmMachine is a rigid type containing Box directly. This is required in a sense that assembly VM needs to know the inner data structures of AsmCoreMachine so as to function. However, It also puts a restriction on AsmMachine: while you can do the following in Rust VM:
as long as Foo implements SupportMachine via a newtype pattern, this is not possible on AsmMachine. However there are certain cases we need wrappers on
Box<AsmCoreMachine>to customize behaviors. This commit introduces a a new traitAsmCoreMachineRevealerbetween AsmMachine and AsmCoreMachine, it provides a mean for users of AsmMachine to customize its behavior, while also requires the presence of AsmCoreMachine, so assembly VM can still function.If only Rust has generic specialization, we won't need to go through all those troubles...