-
Notifications
You must be signed in to change notification settings - Fork 236
deps: make syn and serde_json be workspac dependencies, manualy upgrade bitflags from 1.3 to 2.9 #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
b204182
to
68b69b0
Compare
bitflag's serialization scheme has a breaking change(In my impression, the endianness sorting has changed) from 1.0 to 2.0, which will cause errors in identifying and reading data stored in peer stores. You cannot simply upgrade it. You need to change the default serialization scheme to 1.0 mode, otherwise, it will cause problems with ckb connection and discovery. All other places use internal data. Only the network needs to interact and store data, and consistency must be guaranteed. |
But the Need to review all actions related to the serialization of CKB and bitflags again. |
Just verify whether the conversion between 1.0 and 2.0 is the same in our usage. I remember it is bitflag to u64, then u64 to bitflag. |
ckb/util/gen-types/schemas/extensions.mol Lines 460 to 464 in 17bd37a
2: ckb/util/gen-types/schemas/protocols.mol Lines 43 to 48 in 17bd37a
3: ckb/util/gen-types/schemas/protocols.mol Lines 64 to 67 in 17bd37a
These #[doc = r" Returns the raw value of the flags currently stored."]
#[inline]
pub const fn bits(&self) -> u64 {
self.bits
} This method return same |
9d2f0f5
to
eea09d0
Compare
What problem does this PR solve?
Issue Number: close #4844
Related changes
Check List
Tests
Side effects
Release note