Skip to content

Fix the build of ckb-rocksdb using GCC 15. #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eval-exec wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix the build of ckb-rocksdb using GCC 15. #4906

eval-exec wants to merge 3 commits into from

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Jun 16, 2025

What problem does this PR solve?

This PR want to fix ckb-rocksdb build on gcc15: rust-rocksdb/rust-rocksdb#1007

Related changes

  • Upgrade ckb-rocksdb

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner June 16, 2025 07:16
@eval-exec eval-exec requested review from doitian and removed request for a team June 16, 2025 07:16
@eval-exec eval-exec changed the title Fix ckb-rocksdb build on gcc15 Fix the build of ckb-rocksdb using GCC 15. Jun 16, 2025
@eval-exec
Copy link
Collaborator Author

eval-exec commented Jun 17, 2025

Wait: nervosnetwork/rust-rocksdb#59

@eval-exec eval-exec requested a review from zhangsoledad June 18, 2025 07:32
@eval-exec
Copy link
Collaborator Author

eval-exec commented Jun 30, 2025

Fix ckb-rocksdb build on clang-10: nervosnetwork/rust-rocksdb#63

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale To be closed due to a lack of activity label Aug 18, 2025
doitian
doitian previously approved these changes Aug 18, 2025
View reviewed changes
@github-actions github-actions bot removed the stale To be closed due to a lack of activity label Aug 19, 2025
@eval-exec
Copy link
Collaborator Author

eval-exec commented Nov 27, 2025

@zhangsoledad I think this PR is ready to merge.

@eval-exec eval-exec requested a review from doitian January 4, 2026 03:01
@doitian
Copy link
Member

doitian commented Jan 4, 2026

It seems that libclang is missing in CI

@eval-exec
Copy link
Collaborator Author

eval-exec commented Jan 6, 2026

It seems that libclang is missing in CI

Updated, install llvm on macos, wait for the CI result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

@doitian doitian Awaiting requested review from doitian

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eval-exec @doitian