fix: overhaul proposal selection and prioritization logic #5023
+296
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/fix-txpool-proposal
branch
2 times, most recently
from
e61a27e to
e4018fc
Compare
zhangsoledad
force-pushed
the
zhangsoledad/fix-txpool-proposal
branch
3 times, most recently
from
c8e5857 to
df212c2
Compare
zhangsoledad
force-pushed
the
zhangsoledad/fix-txpool-proposal
branch
3 times, most recently
from
bc896d1 to
4853f0b
Compare
…ing deduplication
…uplicate proposals against previous block
### What problem does this PR solve? Problem Summary: Integration tests in CI is unstable, especially on macOS ### What is changed and how it works? What's Changed: Run test cases in 8 jobs. Run test cases in sequence without concurrency inside jobs. ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - No code
zhangsoledad
force-pushed
the
zhangsoledad/fix-txpool-proposal
branch
from
c44d17e to
eadfec1
Compare
zhangsoledad
requested review from
RetricSu,
chenyukang,
doitian and
eval-exec
and removed request for
RetricSu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed:
This PR fixes a series of logical issues in the tx-pool and block-template construction related to proposal transactions:
Prioritize proposal transactions
Proposals are now given the highest priority in the txpool.
Allow compact block recovery to use transactions from verify_queue
Compact-block reconstruction previously only searched the main pool, leading to unnecessary “missing transaction” failures when a proposal was already in verify_queue. The reconciler now checks pool_map, verify_queue, and the orphan set (when relevant).
Fix proposal selection logic in block template
The previous implementation had several severe bugs:
Related changes
owner/repo:Check List
Tests
Release note