Add fiber-types crate

[chenyukang]

Separate types from fiber-lib.

ref to: fiber-types Crate Design

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

[quake]

can we keep InMemorySigner in fiber-lib crate?

[chenyukang]

it's stored in db by a type chain:

Type `InMemorySigner` is STORE-RELATED (reachable from KeyValue).

Defined in: /Users/yukang/code/fiber/crates/fiber-types/src/channel.rs
Dependency chain(s) from KeyValue:
  KeyValue::ChannelActorState -> ChannelActorState -> ChannelActorData -> InMemorySigner

[quake]

we only use sha256 related fn with this crate , a minimal sha256 crate may be better.

[chenyukang]

we only use bitcoin::hashes::sha256::Hash for type conversion (in primitives.rs and invoice.rs). This conversion is required for interoperability with lightning-invoice, which itself depends on Bitcoin. So even if we remove the direct dependency, it will still be brought in transitively via lightning-invoice?

[chenyukang]

yeah, we can use minimal bitcoin::hashes::sha256.

[chenyukang]

whether we should add a feature gate such as cch .

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.