fix: Offline multisig with complex transaction

[devchenyan]

issue: Magickbase/neuron-public-issues#429

• multisig

Screen-2025-01-06-004004.mp4

• Single signatures

Screen-2025-01-26-111156.mp4

[yanguoyu]

@Danie0918 Is this result expected?

On the other hand, I didn't get the design for this issue.

[Danie0918]

#3260

This popup is as expected and addresses Neuron's inability to sign transactions with unrecognized lock scripts.

[yanguoyu]

#3260

This popup is as expected and addresses Neuron's inability to sign transactions with unrecognized lock scripts.

From #3260, if we skip the unknown lock script. Neuron can sing successfully.

[silySuper]

/package
Packaging for test is done in 12739913571. @silySuper

[Keith-CY]

/package Packaging for test is done in 12739913571. @silySuper

How is this test going?

[silySuper]

/package Packaging for test is done in 12739913571. @silySuper

How is this test going?

Plan to finish tomorrow.

[silySuper]

I have used this json ,brocast fail and does not pop up window.
transaction_duoqian 2.json
Inputs lock is this:

2025-01-16.14.44.30.mov

main.log

[silySuper]

When click Nervos Dao,neuron crash

2025-01-16.15.58.30.mov

main.log
bundled-ckb-lignt-client-testnet.log

[silySuper]

2025-01-23.11.37.16.mov

throw error when click confirm

[devchenyan]

/package
Packaging for test is done in 12923366764. @devchenyan

[silySuper]

Approve flow is abnormal，in expect，export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast

here is actual affect video:

2025-01-23.15.43.46.mov

[devchenyan]

Approve flow is abnormal，in expect，export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast

here is actual affect video:

2025-01-23.15.43.46.mov

The purpose of this requirement is to skip unrecognized inputs and only sign the recognizable ones. However, it does not guarantee that the signed transaction can be successfully broadcast.

@Danie0918 please confirm.

[Danie0918]

Approve flow is abnormal，in expect，export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast
here is actual affect video:
2025-01-23.15.43.46.mov

The purpose of this requirement is to skip unrecognized inputs and only sign the recognizable ones. However, it does not guarantee that the signed transaction can be successfully broadcast.

@Danie0918 please confirm.

It's okay.

[Danie0918]

Single signatures also need to support this feature.

[devchenyan]

Single signatures also need to support this feature.

supported

[Danie0918]

@yanguoyu @homura Please have a review.

[silySuper]

ignore spell wrong

[devchenyan]

ignore spell wrong

fixed

[silySuper]

/package
Packaging for test is done in 12972622182. @silySuper

[silySuper]

Single signatures also need to support this feature.

supported

When click confirm，it shows error.

This is json:
transaction_new.json

[Keith-CY]

Single signatures also need to support this feature.

supported

When click confirm，it shows error.

This is json: transaction_new.json

@devchenyan please check this

[devchenyan]

Single signatures also need to support this feature.

supported

When click confirm，it shows error.

This is json: transaction_new.json

@devchenyan please check this

I'm working on it

[devchenyan]

Approve flow is abnormal，in expect，export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast
here is actual affect video:
2025-01-23.15.43.46.mov

The purpose of this requirement is to skip unrecognized inputs and only sign the recognizable ones. However, it does not guarantee that the signed transaction can be successfully broadcast.
@Danie0918 please confirm.

It's okay.

@silySuper This requirement needs to be able to skip unsigned inputs and export the transaction, so broadcasting may still fail. This situation meets the requirement.

[silySuper]

Approve flow is abnormal，in expect，export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast
here is actual affect video:
2025-01-23.15.43.46.mov

The purpose of this requirement is to skip unrecognized inputs and only sign the recognizable ones. However, it does not guarantee that the signed transaction can be successfully broadcast.
@Danie0918 please confirm.

It's okay.

@silySuper This requirement needs to be able to skip unsigned inputs and export the transaction, so broadcasting may still fail. This situation meets the requirement.

OK.