feat: Add UI crash logs#3328
Merged
Keith-CY merged 2 commits intonervosnetwork:developfrom Mar 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces enhanced logging for UI crashes by updating error handling in the ErrorBoundary component and adding new error logging in the wallet API controller.
- The ErrorBoundary is updated to include component stack information and improved error messages.
- A new call to log errors using logger.error is added in the API controller to aid in debugging.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/neuron-ui/src/components/ErrorBoundary/index.tsx | Enhanced error handling and logging with additional error info and a conditional page reload |
| packages/neuron-wallet/src/controllers/api.ts | Added error logging using logger.error for improved diagnostics |
Keith-CY
approved these changes
Mar 12, 2025
yanguoyu
approved these changes
Mar 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
* feat: Add UI crash logs * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: