Skip to content

chore: update dependency electron to v36.3.1#3353

Merged
Keith-CY merged 2 commits intodevelopfrom
bump-electron-v36
May 27, 2025
Merged

chore: update dependency electron to v36.3.1#3353
Keith-CY merged 2 commits intodevelopfrom
bump-electron-v36

Conversation

@Keith-CY
Copy link
Collaborator

No description provided.

@Keith-CY Keith-CY marked this pull request as ready for review May 25, 2025 23:16
@Keith-CY Keith-CY requested review from Copilot, devchenyan, silySuper and yanguoyu and removed request for silySuper May 25, 2025 23:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Electron dependency from v30.0.0 to v36.3.1 across two packages and modifies the GitHub Actions workflows to use the runner.os variable instead of the matrix.os property.

  • Updated Electron dependency to v36.3.1 in both neuron-wallet and neuron-ui packages.
  • Changed OS condition checks in GitHub Actions workflows from matrix.os to runner.os.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
packages/neuron-wallet/package.json Updated Electron dependency version to v36.3.3.1.
packages/neuron-ui/package.json Updated Electron dependency version to v36.3.1.
.github/workflows/package_for_test.yml Refactored OS condition checks, replacing matrix.os with runner.os for clarity.
.github/workflows/package.yml Refactored OS condition checks, replacing matrix.os with runner.os for consistency.
Comments suppressed due to low confidence (2)

.github/workflows/package_for_test.yml:95

  • Ensure that the runner.os values match the official GitHub Actions OS naming conventions; double-check that 'Windows', 'macOS', and 'Linux' are correctly recognized in the workflow context.
if: runner.os == 'Windows'

.github/workflows/package.yml:112

  • Verify that using 'runner.os' with the value 'macOS' (and similar identifiers) is consistent with GitHub Actions environment outputs to prevent workflow misconfigurations.
if: runner.os == 'macOS'

@Keith-CY Keith-CY force-pushed the bump-electron-v36 branch from 3e00b19 to f10b9aa Compare May 26, 2025 01:27
@Keith-CY
Copy link
Collaborator Author

Please have a review @yanguoyu @devchenyan

@Keith-CY Keith-CY enabled auto-merge May 26, 2025 08:36
@Keith-CY
Copy link
Collaborator Author

@yanguoyu please have a review

@Keith-CY Keith-CY added this pull request to the merge queue May 27, 2025
Merged via the queue into develop with commit c3220f1 May 27, 2025
23 checks passed
@Keith-CY Keith-CY deleted the bump-electron-v36 branch May 27, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants