chore: update dependency electron to v36.3.1#3353
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Electron dependency from v30.0.0 to v36.3.1 across two packages and modifies the GitHub Actions workflows to use the runner.os variable instead of the matrix.os property.
- Updated Electron dependency to v36.3.1 in both neuron-wallet and neuron-ui packages.
- Changed OS condition checks in GitHub Actions workflows from matrix.os to runner.os.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/neuron-wallet/package.json | Updated Electron dependency version to v36.3.3.1. |
| packages/neuron-ui/package.json | Updated Electron dependency version to v36.3.1. |
| .github/workflows/package_for_test.yml | Refactored OS condition checks, replacing matrix.os with runner.os for clarity. |
| .github/workflows/package.yml | Refactored OS condition checks, replacing matrix.os with runner.os for consistency. |
Comments suppressed due to low confidence (2)
.github/workflows/package_for_test.yml:95
- Ensure that the runner.os values match the official GitHub Actions OS naming conventions; double-check that 'Windows', 'macOS', and 'Linux' are correctly recognized in the workflow context.
if: runner.os == 'Windows'
.github/workflows/package.yml:112
- Verify that using 'runner.os' with the value 'macOS' (and similar identifiers) is consistent with GitHub Actions environment outputs to prevent workflow misconfigurations.
if: runner.os == 'macOS'
3e00b19 to
f10b9aa
Compare
Collaborator
Author
|
Please have a review @yanguoyu @devchenyan |
devchenyan
approved these changes
May 26, 2025
Collaborator
Author
|
@yanguoyu please have a review |
yanguoyu
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.