feat: Optimize receive address handling for hardware wallets

[devchenyan]

issue:

• Optimize receive address handling for hardware wallets Magickbase/neuron-public-issues#476

[Keith-CY]

Please add a test for this case and prepend a comment for explanation

[silySuper]

/package

[Keith-CY]

/package
Packaging for test is done in 16591061954. @Keith-CY

[silySuper]

send from new multisig to new multisig receive address is still show wrong address (send address is .....wug,but ledger shows ....yya),send from new multisig to old multisig shows OK now

[Keith-CY]

send from new multisig to new multisig receive address is still show wrong address (send address is .....wug,but ledger shows ....yya),send from new multisig to old multisig shows OK now

Please export the transaction for debug

[silySuper]

transaction_1753780324604.json

[Keith-CY]

transaction_1753780324604.json

The first output is

"lock": {
          "args": "0xebd35235715d12e36ca60396d7d3ce630d6aaacd",
          "codeHash": "0x36c971b8d41fbd94aabca77dc75e826729ac98447b46f91e00796155dddb0d29",
          "hashType": "data1"
        },

and its address is

ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug

So the address ends with yya is incorrect.

Please import this transaction again and take a photo of the displayed receiver address so we can parse it into script for further debug

[Keith-CY]

ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug

I have reproduced this case with my Ledger and will upload the photo later

[Keith-CY]

I'm sending 100 CKB to ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug with a Ledger

The destination address is displayed as follows

I wrote it down ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq0t6dfr2u2azt3kefsrjmta8nnrp4424ng74eyya

The code hash and hash type is incorrect

While the transaction has been suceesfully signed

transaction_1753850370140.json

[Keith-CY]

I'm sending 100 CKB to ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug with a Ledger

The destination address is displayed as follows

While the transaction has been suceesfully signed

transaction_1753850370140.json

I just broadcast this transaction at https://testnet.explorer.nervos.org/transaction/0x727c1379986ffe2b81508ba091f40b6d13aa5bddbaa04197b01dfb38263e1a46

[Keith-CY]

I'm sending 100 CKB to ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug with a Ledger

The destination address is displayed as follows

I wrote it down ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq0t6dfr2u2azt3kefsrjmta8nnrp4424ng74eyya

The code hash and hash type is incorrect

While the transaction has been suceesfully signed

transaction_1753850370140.json

My bad, I should install the test nervos app for ledger, how can I install it @silySuper

[Keith-CY]

I've sideloaded nervos app v0.6.0 and built a transaction to ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug. The destination is correct

But when I tweaked the hash type to data2 and the address became ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjp8t6dfr2u2azt3kefsrjmta8nnrp4424ngnfgdg7, the destination address is still ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug

Ref:

• nervos app: https://github.com/XuJiandong/app-nervos/actions/runs/16409824850
• before sign:
  before_sign.json
• after sign:
  after_sign.json
• on chain: https://testnet.explorer.nervos.org/transaction/0x65511a9d41e211f1ed0fcab22a82518ce6aebebfc93576168f85835916642d6b

[Keith-CY]

I've reproduced the case @silySuper had encoutered.

The target address is

ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqht6dfr2u2azt3kefsrjmta8nnrp4424ngf4rwug

but when I initiated a transfer from a multisig address
ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqsgy9aawlk2zxn7sevst0v6hvg2pmmmnsgkd3hxxckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqsgy9aawlk2zxn7sevst0v6hvg2pmmmnsgkd3hxx.

The destination address displayed on Ledger is ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq0t6dfr2u2azt3kefsrjmta8nnrp4424ng74eyya

lock_script before and after sign are both multisig & data_1 while the destination address on ledger's is secp256k1 & type

The change address displayed on Ledger is

ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqggy9aawlk2zxn7sevst0v6hvg2pmmmnsgpdta7n

The secp256k1/sighash version of the original multisig address

Ref:

• before sign: before_sign.json
• after sign: after_sign.json

[silySuper]

verified