multiaddr: Support Onion Protocol#396
Merged
driftluo merged 2 commits intonervosnetwork:masterfrom Feb 19, 2025
Merged
Conversation
Signed-off-by: Eval EXEC <execvy@gmail.com>
….com/multiformats/rust-multiaddr/blob/7a6c81f15a648d841e9aede5edf6c5620dc489b4/tests/lib.rs Signed-off-by: Eval EXEC <execvy@gmail.com>
eval-exec
force-pushed
the
exec/onion-protocol
branch
from
83e0f6b to
c765595
Compare
driftluo
approved these changes
Feb 19, 2025
quake
reviewed
Feb 19, 2025
| Ok(input.split_at(n)) | ||
| } | ||
|
|
||
| fn split_at(n: usize, input: &[u8]) -> Result<(&[u8], &[u8]), Error> { |
Member
There was a problem hiding this comment.
this fn is same as split_header, why not reuse it?
Collaborator
There was a problem hiding this comment.
I will remove split_at on next release pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onion3variants for ProtocolThe code changes are copied from https://github.com/multiformats/rust-multiaddr/blob/master/src/onion_addr.rs
(No need to support Onion v2, it has been deprecated: https://support.torproject.org/onionservices/v2-deprecation/)