Skip to content

Rust Toolchain: Upgrade to rust edition 2024#402

Merged
driftluo merged 2 commits intonervosnetwork:masterfrom
eval-exec:exec/upgrade-rust-2024
Apr 1, 2025
Merged

Rust Toolchain: Upgrade to rust edition 2024#402
driftluo merged 2 commits intonervosnetwork:masterfrom
eval-exec:exec/upgrade-rust-2024

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec requested a review from driftluo as a code owner March 7, 2025 04:16
@eval-exec eval-exec marked this pull request as draft March 7, 2025 04:16
@eval-exec eval-exec marked this pull request as ready for review March 27, 2025 06:52
@eval-exec eval-exec marked this pull request as draft March 27, 2025 06:53
@eval-exec eval-exec marked this pull request as ready for review March 27, 2025 08:52
@eval-exec
Copy link
Collaborator Author

eval-exec commented Mar 27, 2025

Hello, @driftluo, Do I need to squash these 7 commits into 1 commit?

@eval-exec eval-exec force-pushed the exec/upgrade-rust-2024 branch from 351a60e to 22d20c8 Compare March 27, 2025 08:54
@eval-exec eval-exec force-pushed the exec/upgrade-rust-2024 branch from 22d20c8 to c9592da Compare April 1, 2025 05:04
@eval-exec
Copy link
Collaborator Author

Squashed multiple commits into one commit.

@eval-exec eval-exec marked this pull request as draft April 1, 2025 05:07
@eval-exec
Copy link
Collaborator Author

eval-exec commented Apr 1, 2025

@driftluo , we can delete these unstable cfg now:

#[cfg(feature = "unstable")]
#[cfg_attr(docsrs, doc(cfg(feature = "unstable")))]

@eval-exec eval-exec force-pushed the exec/upgrade-rust-2024 branch from c9592da to db809bc Compare April 1, 2025 05:55
@eval-exec eval-exec marked this pull request as ready for review April 1, 2025 05:59
@eval-exec eval-exec force-pushed the exec/upgrade-rust-2024 branch from 0890385 to 4693f4a Compare April 1, 2025 06:01
@driftluo
Copy link
Collaborator

driftluo commented Apr 1, 2025

@driftluo , we can delete these unstable cfg now:

#[cfg(feature = "unstable")]
#[cfg_attr(docsrs, doc(cfg(feature = "unstable")))]

I personally think that the runtime needs to be unstable. There is no feedback from spawn yet, and the API cannot be guaranteed. It is also not possible to stabilize the API for the time being.

@eval-exec eval-exec force-pushed the exec/upgrade-rust-2024 branch from 4693f4a to 334bf7b Compare April 1, 2025 06:29
@eval-exec
Copy link
Collaborator Author

eval-exec commented Apr 1, 2025

@driftluo , we can delete these unstable cfg now:

#[cfg(feature = "unstable")]
#[cfg_attr(docsrs, doc(cfg(feature = "unstable")))]

I personally think that the runtime needs to be unstable. There is no feedback from spawn yet, and the API cannot be guaranteed. It is also not possible to stabilize the API for the time being.

Ok, I have reverted it.

@eval-exec eval-exec requested a review from driftluo April 1, 2025 06:31
@eval-exec eval-exec force-pushed the exec/upgrade-rust-2024 branch from 334bf7b to f51ff41 Compare April 1, 2025 06:42
@driftluo driftluo merged commit 9cb5985 into nervosnetwork:master Apr 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants