[Android standalone] update SDL files to v2.32.10 #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to selective update the file, butt there were a multiline comment I mislook. So I just updated he full file SDLActivity.java file.
Contributor
Author
|
The Android Apk doesn't crash anymore! But the keyboard is not showing up. I can fix it, just give me a bit of time. |
[Gemini 2.5 Pro] The custom virtual keyboard on Android is no longer displayed after updating the underlying SDL library from v2.26.2 to v2.32.10. This was caused by a change in how the new version of `SDLActivity.java` handles text input. The newer SDL version more aggressively activates its own text input system (`SDL_StartTextInput()`) on Android. The TIC-80 C code in `src/system/sdl/main.c` has a function, `isKbdVisible()`, which determines whether to render the custom keyboard. This function contained a specific check for Android: `!SDL_IsTextInputActive()`. This line was intended to hide the custom keyboard when a native (e.g., system) keyboard was active. Because the newer SDL version keeps its text input system active by default, this check was causing the custom TIC-80 keyboard to be permanently hidden. This change resolves the issue by commenting out the `!SDL_IsTextInputActive()` check. This restores the intended behavior, ensuring that TIC-80's own integrated virtual keyboard is always used for input on touch devices, independent of the underlying SDL text input state.
Tries to make the system keyboard show when it was previously working.
The virtual keyboard was not appearing after updating SDL to v2.32.10. The new `SDLActivity.java` now enables text input on launch by default, which caused TIC-80's logic to hide its custom keyboard. This is fixed by adding an explicit `SDL_StopTextInput()` call during initialization to restore the correct default state. A redundant text input call was also removed from the `SDL_KEYDOWN` handler to ensure the system keyboard is only activated by its specific toggle key.
Contributor
Author
|
This is now working on my device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDL2 update (86a4cc3) worked great on all plataforms, but on Android that got crashes.