Skip to content

Conversation

@imsys
Copy link
Contributor

@imsys imsys commented Sep 11, 2025

Saves 711 MiB of disk space by adding the msf_gif header file instead of the whole repo that contains mostly test cases.
It saves 354 MiB of bandwidth, but it is stored twice, in .git/modules/vendor/msf_gif and vendor/msf_gif, so that's why it takes double the size.

The full TIC80 repo after getting all the submodules, before making any build takes 1203.7 MiB, so this lib alone was taking 59% of disk space. I verified and it was due to many test cases that are unnecessary to the TIC80 project.

CMake Error at vendor/zip/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.
-- Configuring incomplete, errors occurred!

Update the VERSION argument <min> value.  Or, use the <min>...<max>
syntax
to tell CMake that the project requires at least <min> but has been
updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
@imsys
Copy link
Contributor Author

imsys commented Sep 11, 2025

Discussed in the previous pull request #2830

@imsys
Copy link
Contributor Author

imsys commented Sep 11, 2025

During the first build, the HTML build job failed with the error:
OSError: [Errno 39] Directory not empty: 'joystick'

Github copilot says it was a bad luck during the cmake --parallel and suggested to remove the parallel.
https://github.com/copilot/share/8215410e-4be0-80c2-9812-94098046484e

Maybe by removing the msf_gif repo makes a faster build, that increases the chances of parallel build errors? idk.
Maybe it was just bad luck and it's still work keeping the parallel.

But we keep this in mind in case we stumble upon the same problem.

@imsys imsys changed the title Includes the msf_gif.h in the project instead of using the full repo (saves 711 MiB of disk space) Includes the msf_gif.h in the project instead of using the full repo (saves 711 MiB of disk space) & MacOs Build Fix Sep 11, 2025
@imsys imsys changed the title Includes the msf_gif.h in the project instead of using the full repo (saves 711 MiB of disk space) & MacOs Build Fix Replace msf_gif submodule with single header (–711 MiB) + macOS build fix Sep 11, 2025
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think you need to add yourself to the credits in readme.md in one of the future pull requests.

@github-project-automation github-project-automation bot moved this to In progress in dev version 1.2 Sep 12, 2025
@nesbox nesbox merged commit b98d07c into nesbox:main Sep 12, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in dev version 1.2 Sep 12, 2025
@imsys
Copy link
Contributor Author

imsys commented Sep 13, 2025

Sure, but I’ll send a few more contributions before adding to the credits. :)
I’m kind of on vacation, and I plan to dedicate about two weeks to the TIC-80 project.
My goal is to fix most of the games that were broken by regressions. I think I’ve identified about three or four different cases (or causes).

After that, there’s a very difficult task that I’m not completely sure I can solve. Some games run too slowly on cheap retro handhelds, like the Emuurom and others. I’m not sure if the issue comes from the libretro core specifically, or if the standalone version on those devices has the same slowdown. Either way, I plan to investigate and try to improve performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants