[cmake/mruby.cmake] Replace exec_program (deprecated)
#2869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
|
Relevant PR #2845 |
nesbox
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exec_programcommand has been deprecated since CMake 3.0, in favor ofexecute_process.This change will also fix the build failure in the Nixpkgs
tic-80derivation on macOS, although that's not really related to the deprecation. (Nixpkgs is using a fakexcruncommand fromxcbuild, which outputs a warning message before returning the SDK path.exec_commandcaptures both stdout and stderr in the same variable, causing the warning to end up in the Makefile and breaking things.execute_processhandles stdout and stderr separately, so it doesn't have this problem.)