fix: preserve clarify fallback ownership#3071
Merged
1 commit merged intoMay 28, 2026
Merged
Conversation
nesquena-hermes
closed this pull request by merging all changes
into
nesquena:master
in
b103f4a
Collaborator
|
Shipped in v0.51.153 / Release DY (stage-batch35, commit b103f4a). Thanks for the contribution! |
AJV20
pushed a commit
to AJV20/hermes-webui
that referenced
this pull request
May 28, 2026
# Conflicts: # CHANGELOG.md
AJV20
pushed a commit
to AJV20/hermes-webui
that referenced
this pull request
May 28, 2026
11-PR low-risk cleanup: - nesquena#3043 openai-codex models.dev reasoning passes xhigh - nesquena#3044 reset _messagesTruncated on new session - nesquena#3047 discoverability: api lineage representative for stale CLI flag - nesquena#3049 title-language detection threshold + English false-positive fix - nesquena#3051 docker docs: sudo compose + Linux host-gateway - nesquena#3054 SSE reconnect: visible-but-unfocused current pane - nesquena#3055 fallback title: drop German-only Session Bilder case - nesquena#3056 title prompt: language-neutral instruction - nesquena#3070 /api/upload reports actual stored filename - nesquena#3071 clarify SSE fallback preserves owner session id - nesquena#3072 gateway-chat forwards image attachments as image_url parts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Approval polling keeps its owner session when SSE falls back to polling. Clarify polling had an asymmetric path: its SSE
onerrorcalled the full stop helper before starting fallback polling, briefly clearing_clarifyPollingSessionIdand allowing later terminal cleanup from another session to stop the active fallback poller.What Changed
onerrornow closes only the SSE/health resources before starting fallback polling._startClarifyFallbackPoll(sid)explicitly records the fallback owner session id.Verification
node --check static/messages.jspython3.11 -m pytest tests/test_session_runtime_ownership_invariants.py tests/test_1694_prompt_ownership.py -q -o addopts=(12 passed)git diff --check origin/master...HEAD