feat(announcements): pass summary through validator and show in banner - #86
Merged
Merged
Conversation
…title in banner Adds optional `summary` field on the `Announcement` interface, wires it through the feed validator (capped at 240 chars; over-cap drops the summary but keeps the entry, with a debug log line), and renders it inline after the title in the desktop banner with an em-dash separator and slightly dimmed text so the title stays the primary affordance. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summary?: stringto theAnnouncementinterface.summarythrough when present, drops it (keeping the entry) if it exceedsMAX_SUMMARY_LEN = 240, and logs a[announcements]line so the drop is observable.text-accent/80); title stays the only clickable affordance.Coordination
Pairs with the sibling
site-announcements-page-chat-mode-postworktree, which will be free to start includingsummaryinsite/public/announcements.jsononce this lands. This PR deliberately does not touchannouncements.json.Test plan
npm run typechecknpx electron-vite buildnpx vitest run(635/635 passing)npm run dev: confirm banner showstitle — summary, that an entry withoutsummaryrenders cleanly with no stray em-dash, and that a 300-char summary falls back to title-only with a[announcements]debug log line.🤖 Generated with Claude Code