-
Notifications
You must be signed in to change notification settings - Fork 376
Port test_issue_1974 from SLI to Py #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@JanVogelsang This one fails currently on macOS, I believe, because we skip the test when Music is not present, which confuses the result collection process. I will need to think about the skipping logic for these MPI tests once again. It also seems that this PR contains many more files than it should. It would be good to wait with this one until we have #3450 merged. |
@JanVogelsang Could you review #3467? Once that is in place it should be straightforward to implement music-skipping by decorator here. |
@heplesser I implemented the music-skipping decorator and added it to the isuee_1974 python test. |
Blocked by #3470 |
@JanVogelsang This looks in principle good to me now, but I would prefer to merge #3450 first so that the change set for this PR becomes smaller, reduced to just the port of the test and the missing-music decorator. |
|
@heplesser Can you rerun the test-suite now that the CI issue is merged? |
Yes, I agree. We just need Dennis to take a very quick look at #3445 |
@JanVogelsang If think you need to merge master into your branch for this PR so the Ubuntu-update in master takes effect here. That should automatically trigger the CI. |
There still is an issue with the Python-version, as it triggers the "assert_thread_parallel" assertion (line 207 in vp_manager.cpp). I am not sure why, @heplesser could you take a look at that?