test(common): improve test coverage for shared utils #14832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests for edge cases in shared utility functions - Fix issues with normalizePath and isEmpty
Pull Request Test Coverage Report for Build 949bf200-490f-4ef9-bad7-32d6f1bf014eDetails
💛 - Coveralls |
micalevisk
reviewed
Mar 23, 2025
- Fix isEmptyArray to return false for non-array values and array-like objects - Update tests to align with the new behavior - Add comprehensive test coverage for edge cases
I got an error when running npm run test:coverage. The @nestjs/graphql package depends on the isEmpty function from @nestjs/common. After renaming isEmpty to isEmptyArray, the @nestjs/graphql package can no longer find the isEmpty function, leading to the error. To fix this issue, I restored the isEmpty function for the @nestjs/graphql package.
micalevisk
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Add tests for edge cases in shared utility functions
Adding type safety
Update normalizePath, isEmpty, stripEndSlash
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information