sample(sample/10): add unit and e2e tests for 10-fastify #15873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 0dfa1dfb-2666-4601-b521-80558e1a8704Details
💛 - Coveralls |
fix(sample/10): fix id generation and controller return values - fix bug in CatsService (id generation) - fix multiple bugs in CatsController (no return, @res() usage) feat(sample/10): add full test coverage - add complete unit test suite for CatsService - add complete e2e test suite for CatsController - add Jest config and dependencies to the sample Fixes nestjs#1539
psyberpath
force-pushed
the
feat/sample-10-tests
branch
from
dc3f333 to
cb9dfd8
Compare
psyberpath
changed the title
psyberpath
changed the title
Author
|
hi. it's being a couple of days and i'd like to know if there's an issue with my request. please let me know so i can fix it and align with the ideal. |
Hardanish-Singh
approved these changes
Nov 8, 2025
Hardanish-Singh
approved these changes
Nov 9, 2025
Hardanish-Singh
approved these changes
Nov 13, 2025
micalevisk
reviewed
Dec 9, 2025
Member
|
Could you please resolve merge conflicts? |
Co-authored-by: Micael Levi L. Cavalcante <[email protected]>
Member
|
Author
|
I'm working on it. will push once done. thanks for the review. |
…rrors and reinstalled @types/jest dev dependency
Author
|
I have fixed the configuration issue. tsconfig.json wasn't explicitly loading the jest types, so the compiler didn't see them even though the tests ran fine. I have updated tsconfig.json and also installed @types/jest, so the errors are now gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(sample/10): fix id generation and controller return values
feat(sample/10): add full test coverage
Fixes #1539
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information