Skip to content

Conversation

@psyberpath
Copy link

@psyberpath psyberpath commented Nov 3, 2025

fix(sample/10): fix id generation and controller return values

  • fix bug in CatsService (id generation)
  • fix multiple bugs in CatsController (no return, @res() usage)

feat(sample/10): add full test coverage

  • add complete unit test suite for CatsService
  • add complete e2e test suite for CatsController
  • add Jest config and dependencies to the sample

Fixes #1539

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Nov 3, 2025

Pull Request Test Coverage Report for Build 44468ac0-6bb2-41e3-a31a-00d0660d9852

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.927%

Totals Coverage Status
Change from base Build b32a1fdd-a4bd-48bf-b78e-fc5a6de9794e: 0.0%
Covered Lines: 7324
Relevant Lines: 8236

💛 - Coveralls

fix(sample/10): fix id generation and controller return values
- fix bug in CatsService (id generation)
- fix multiple bugs in CatsController (no return, @res() usage)

feat(sample/10): add full test coverage
- add complete unit test suite for CatsService
- add complete e2e test suite for CatsController
- add Jest config and dependencies to the sample

Fixes nestjs#1539
@psyberpath psyberpath force-pushed the feat/sample-10-tests branch from dc3f333 to cb9dfd8 Compare November 3, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc request] Add unit/e2e tests to repo's samples

2 participants