build: replace benchmarks #16271
Merged
build: replace benchmarks #16271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build cd5b6847-3ae5-438b-b448-e06c0093aa71Details
💛 - Coveralls |
micalevisk
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the existing benchmarking infrastructure, removing the deprecated Artillery dependency and implementing a new custom benchmark system using autocannon. The changes reduce the dependency footprint by 499 packages.
Changes:
- Removed Artillery, wrk, @codechecks/client, and related dependencies
- Implemented new benchmark system in tools/benchmarks with TypeScript
- Created framework test servers for Express, Fastify, Nest-Express, and Nest-Fastify
- Added autocannon as the new benchmarking tool
Reviewed changes
Copilot reviewed 23 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/benchmarks/tsconfig.json | TypeScript configuration for benchmarks |
| tools/benchmarks/src/main.ts | Main benchmark orchestration logic |
| tools/benchmarks/src/autocannon/run.ts | Autocannon wrapper utility |
| tools/benchmarks/src/frameworks/*.ts | Framework-specific server implementations |
| tools/benchmarks/package.json | Benchmark-specific dependencies |
| tools/benchmarks/package-lock.json | Lock file for benchmark dependencies |
| package.json | Removed unused benchmark dependencies from root |
| eslint.config.mjs | Code style formatting updates |
| benchmarks/* | Removed old benchmark files |
| tools/benchmarks/get-benchmarks.ts | Removed old benchmark getter |
| tools/benchmarks/check-benchmarks.ts | Removed old benchmark checker |
Files not reviewed (1)
- tools/benchmarks/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
merged changes from master and added fix from review |
Member
|
Could you resolve merge conflicts? |
Contributor
Author
|
@kamilmysliwiec Sure! done |
|
Well, this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently nests has artillery as dependency but it does not used
Issue Number: N/A
What is the new behavior?
I reworked benchmarks and removed unused dependencies. 499 packages less will be installed. Also with #16231 PR it should resolve two critical vulnerabilities.
Does this PR introduce a breaking change?
Other information