test(microservices): verify kafka run options forwarding #16326
Merged
+38
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #14590
ServerKafkaforwardsoptions.runto KafkaJSconsumer.run(), but there is no explicit test coverage proving thatoptions.run.*is passed through without being dropped/filtered. Also,partitionsConsumedConcurrentlyis easy to misunderstand as topic-level concurrency although it is partition-level in KafkaJS.What is the new behavior?
Adds test coverage to verify
options.run.*is passed to KafkaJSconsumer.run()and includeseachMessagehandler, plus adds a short JSDoc note clarifying thatpartitionsConsumedConcurrentlycontrols partition-level concurrency (KafkaJS parameter), not topic-level.Summary
packages/microservices/test/server/server-kafka.spec.tsto verify:partitionsConsumedConcurrentlyis forwarded toconsumer.run()options.runfields (e.g.autoCommit,autoCommitInterval) are forwarded as wellKafkaOptions.runinpackages/microservices/interfaces/microservice-configuration.interface.tsDoes this PR introduce a breaking change?
Other information
Test Plan
npm test npm run lint npm run buildNotes
partitionsConsumedConcurrently).