feat(microservices): add topic-consumers option to server-kafka#16555
Open
suuuuuuminnnnnn wants to merge 5 commits intonestjs:masterfrom
Open
feat(microservices): add topic-consumers option to server-kafka#16555suuuuuuminnnnnn wants to merge 5 commits intonestjs:masterfrom
suuuuuuminnnnnn wants to merge 5 commits intonestjs:masterfrom
Conversation
Coverage Report for CI Build 0Coverage decreased (-0.06%) to 89.815%Details
Uncovered Changes
Coverage Regressions109 previously-covered lines in 14 files lost coverage.
Coverage Stats
💛 - Coveralls |
Member
|
Any chance to add an integration test for this, too? |
Contributor
Author
|
sure — i can add an integration test as well. i’ll put together an e2e test that exercises the option end-to-end and ensures it’s propagated correctly, then update the pr. |
998f293 to
bade813
Compare
|
Hi, The new Severity: informational | Category: reliability How to fix: Gate test via env flag Agent prompt to fix - you can give this to your LLM of choice:
Found by Qodo code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ServerKafkauses a single KafkaJS consumer subscribed to all registered topics, so a slow handler on one topic can effectively block message processing on other topics (topic-level backpressure). Partition-level concurrency (partitionsConsumedConcurrently) does not address cross-topic blocking.Issue Number: #14590
What is the new behavior?
Adds an opt-in
topicConsumers: booleanoption for Kafka microservices.When
topicConsumers: true:{groupId}-{topic}as the consumer group id (independent offset tracking per topic)close()options.runwhen building per-topicrun()optionsDefault remains
false, preserving the existing single-consumer behavior.Does this PR introduce a breaking change?
Note: enabling
topicConsumers: truecreates new consumer groups ({groupId}-{topic}), so migrating an existing deployment may require offset management.Other information
Tests
npm test -- packages/microservices/test/server/server-kafka.spec.tsAll tests pass, including new unit tests for
topicConsumersmode.