feat(microservices): add return buffers option for binary data#16676
feat(microservices): add return buffers option for binary data#16676Forceres wants to merge 2 commits intonestjs:masterfrom
Conversation
Pull Request Test Coverage Report for Build 472dd428-2ae6-4d12-bfd5-a48cbbd1c630Details
💛 - Coveralls |
|
Could you please add an integration test for this as well? |
Yeah, give me some time. |
|
Hi, Severity: action required | Category: maintainability How to fix: Add returnBuffers to options types Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Spotted by Qodo code review - free for open-source projects. |
|
Hi, When Severity: remediation recommended | Category: maintainability How to fix: Widen callback param type Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Found by Qodo code review |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Now we can't directly get buffers from redis, so any custom binary formats are broken. Moreover, our redis output has to be json that contradicts to custom binary formats.
What is the new behavior?
We can pass returnBuffers to client options for listening on "messageBuffer" instead of "message" to get directly buffers from redis. createResponseCallback handles jsons as well as binary (but we have to pass custom deserializer to decode id from it)
Does this PR introduce a breaking change?