fix(socket.io): Deduplicate disconnect listener in bindMessageHandlers#16742
Open
fru1tworld wants to merge 2 commits intonestjs:masterfrom
Open
fix(socket.io): Deduplicate disconnect listener in bindMessageHandlers#16742fru1tworld wants to merge 2 commits intonestjs:masterfrom
fru1tworld wants to merge 2 commits intonestjs:masterfrom
Conversation
Coverage Report for CI Build 26Coverage remained the same at 89.907%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache the
disconnect$observable per socket using aWeakMapso that multiple gateways sharing the same Socket.IO server register only onedisconnectlistener per client socket instead of one per gateway.Changes
WeakMap<Socket, Observable>toIoAdapterto cachedisconnect$per socket.bindMessageHandlersnow reuses the cached observable on subsequent calls for the same socket.disconnectlistener is registered regardless of call count.Manual test / verification
npm run test— all 2003 unit tests passing.npx prettier --check— formatting OK.npm run lint:packages— no errors.Fixes #7249