chore(swagger): include model name in circular dependency warning #3353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Right now nest shows something like this:
Error: A circular dependency has been detected (property key: "id"). Please, make sure that each side of a bidirectional relationships are using lazy resolvers ("type: () => ClassType").
. If you've changed / refactored few files in your repo you probably don't easily know with Model had the error (and since the error occurred in theid
field for me, it could've been basically any)What is the new behavior?
We're now checking if there is a
pendingSchemaRef
. As far as I understood the code this is a list of models to work on. In my testing the first item always equaled the model that the error was thrown so I thought it might be a good idea to include the model name in the error message.If I was just "lucky" and the order of the
pendingSchemaRefs
isn't actually sorted in any way making the error message invalid, I guess we can close this (if there is no other easy way to infer the models name)Does this PR introduce a breaking change?