Skip to content

Adding qos policies to routed interface templates #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juarocha wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Adding qos policies to routed interface templates #751

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dee8a3e
Adding qos policies to routed interface templates
juarocha Mar 19, 2026
dd6079b
Merge branch 'netascode:develop' into fix-routed-int-qos
juarocha May 4, 2026
640765b
Merge branch 'netascode:develop' into fix-routed-int-qos
juarocha May 6, 2026
d3226d9
Fixing routed ports qos defaults
juarocha May 6, 2026
8b8374e
Merge branch 'netascode:develop' into fix-routed-int-qos
juarocha Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_po_routed.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
speed: {{ interface['speed'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_po_interface.speed) }}
pc_mode: "{{ interface['pc_mode'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_po_interface.pc_mode) }}"
members: {{ interface['members'] | default(omit) }}
enable_qos: {{ interface['enable_qos'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.enable_qos) | lower }}
{% if interface['enable_qos'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.enable_qos) %}
Comment thread
juarocha marked this conversation as resolved.
Outdated
qos_policy: {{ interface['qos_policy'] | default("") }}
queuing_policy: {{ interface['queuing_policy'] | default("") }}
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
{% endif %}
Expand Down
5 changes: 5 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_routed.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
int_vrf: {{ interface['vrf'] | default(omit) }}
mtu: {{ interface['mtu'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_interface.mtu) }}
speed: {{ interface['speed'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_interface.speed) }}
enable_qos: {{ interface['enable_qos'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.enable_qos) | lower }}
{% if interface['enable_qos'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.enable_qos) %}
Comment thread
juarocha marked this conversation as resolved.
Outdated
qos_policy: {{ interface['qos_policy'] | default("") }}
queuing_policy: {{ interface['queuing_policy'] | default("") }}
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
{% endif %}
Expand Down
6 changes: 4 additions & 2 deletions roles/validate/files/defaults.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ factory_defaults:
enable_lacp_vpc_convergence: false
lacp_port_priority: 32768
lacp_rate: normal
monitor: false
enable_qos: false
monitor: false
topology_switch_trunk_po_interface:
description: "NetAsCode Trunk PO Interface"
mtu: jumbo
Expand All @@ -215,8 +215,8 @@ factory_defaults:
enable_lacp_vpc_convergence: false
lacp_port_priority: 32768
lacp_rate: normal
monitor: false
enable_qos: false
monitor: false
topology_switch_dot1q_interface:
description: "NetAsCode Dot1q Interface"
mtu: jumbo
Expand All @@ -232,6 +232,7 @@ factory_defaults:
mtu: 9216
speed: auto
enabled: true
enable_qos: false
topology_switch_routed_sub_interface:
description: "NetAsCode Routed Sub Interface"
mtu: 9216
Expand All @@ -243,6 +244,7 @@ factory_defaults:
speed: auto
enabled: true
pc_mode: active
enable_qos: false
topology_switch_loopback_interface:
description: "NetAsCode Loopback Interface"
enabled: true
Expand Down
Loading