Refactor collection#790
Open
mikewiebe wants to merge 83 commits into
Open
Conversation
…-vxlan into refactor_collection
* Update pipeline_base.py Add Skip_validation for ISN fabric * Update ndfc_executor.py add skip_validation flag for dcnm_fabric * Update pipeline_base.py add use case for external fabric * Update pipeline_base.py add eBGP_VXLAN use case * Update create_resources.yml * Update pipeline_base.py * Update pipeline_base.py * Update ndfc_executor.py
* Improve role validate performance * Improve mark stage complete tasks * Build resources performance improvements
…-vxlan into refactor_collection
* Update ndfc_underlay_ip_address.j2 * Update ndfc_bgw_anycast_vip.j2 * Update create_resources.yml
* Bulk API for Hostname Fabric Policy Get * Fix Sanity * Fix Pep8
* Update create_resources.yml * Update manage_resources.py * Create underlay_ip_manual_allocation_filter.py * Update create_resources.yml * Update manage_resources.py * Update manage_resources.py * Update underlay_ip_manual_allocation_filter.py * Address PR #773 review comments: single-pass optimization, remove Tier 3 fallback, fix verbosity, remove dead code - Merge extract/filter/index into single-pass loop (review comment #1) - Move pools list logging from -vv to -vvv (review comment #2) - Remove Tier 3 pool+resource fallback, keep two-tier only (review comment #3) - Remove unused underlay_ip_audit_pools and underlay_ip_audit_scope_filter (review comment #4) Note: After dcnm_resource_manager updates pool allocations, a Recalculate and Deploy is required for changes to be applied to device configuration.
Enable CI tests on refactor_collection. Remove before merge to develop
* Update manage_resources.py * Move fabric links profile comparison into existing_links_check - Move value-level profile comparison from manage_resources.py prefilter into existing_links_check.py during endpoint matching (single pass) - Add _link_profile_changed() method with forward check (desired vs controller) and reverse check (field removal detection for peer1_cmds/peer2_cmds) - Remove redundant second-pass prefilter from manage_resources.py - Both YAML and Python pipeline callers now benefit from profile filtering Addresses review comments on PR #794. * Update manage_resources.py
* Update diff_compare.py for policy * Update manage_resources.py add remote policies diff * Update create_resources.yml * Update resource_types.yml * Update manage_resources.py * Update diff_compare.py * Update manage_resources.py * Address PR #784 review: clean policy diff, resolve merge conflict, add use_desc_as_key - Remove extra }, in diff_compare.py (review comment #1) - Rewrite manage_resources.py policy diff to use per-switch API (review comment #2) - Remove dead code: _fetch_all_policy_pages, urlencode import, ndfc_internal_keys - Remove all DEBUG blocks from manage_resources.py and pipeline_base.py - Resolve merge conflict: integrate _underlay_ip_remote_diff from upstream - Add use_desc_as_key=True for dcnm_policy in ndfc_executor.py (fixes changed=False bug) * Update diff_compare.py * Update manage_resources.py * Fix E131 pep8: use parenthesized ternaries for hanging indent
* Fix MCFG Fabric Handling * Fix Lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Related Collection Role
Related Data Model Element
Proposed Changes
Test Notes
Cisco Nexus Dashboard Version
Checklist