Skip to content

Add display of ID if user does not have email #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2025
Merged

Add display of ID if user does not have email #450

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36616ed
Add display of ID if user does not have email
tropnikovvl Mar 21, 2025
ac02893
Update PeerNameCell.tsx
tropnikovvl Mar 21, 2025
5e56e06
Add more possible id parameters
tropnikovvl Mar 21, 2025
31e6d97
Hide user if there is nothing
tropnikovvl Mar 21, 2025
a391804
change id order
tropnikovvl Mar 27, 2025
8a3cf96
Keep default behavior
tropnikovvl Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/peers/PeerNameCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default function PeerNameCell({ peer, linkToPeer = true }: Props) {
}
>
<div className={"text-nb-gray-400 font-light truncate"}>
{userOfPeer?.email}
{!userOfPeer?.email && userOfPeer?.id}
Copy link

@nazarewk nazarewk Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably be userOfPeer?.email || userOfPeer?.name || userOfPeer?.user_id || userOfPeer?.id:

  • email would come first as usual
  • name second as it's still user readable
  • synchronized user_id from IdP (usually not readable)
  • internal object id for the user (never readable)

the existing construct looks weird to me, but I didn't write JS for a decade so don't take my word on it.

Copy link
Contributor Author

@tropnikovvl tropnikovvl Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the code and made sure it works.

Copy link

@nazarewk nazarewk Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing that I thought of, we should probably prefix the user_id/id with "user:" string, but I'm not sure how to type it out correctly in TypeScript or JS.

Copy link
Contributor Author

@tropnikovvl tropnikovvl Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that it will look like this in the end?
Screenshot 2025-03-21 at 17 28 36

Copy link

@nazarewk nazarewk Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tropnikovvl exactly what you screenshotted
on the UX side, we could end the series of ||s with "<unknown>" so it's obvious nothing was found instead of id being "undefined" string

Copy link

@nazarewk nazarewk Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, actually we shouldn't output anything at all when the user is undefined, this will simply mean there is no user attached to the peer

Copy link

@nazarewk nazarewk Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like (pseudocode):

user = userOfPeer?.email || userOfPeer?.name
userId = peer?.user_id || userOfPeer?.id
if !user && userId {
	user = `user:${userId}`
}

Copy link
Contributor Author

@tropnikovvl tropnikovvl Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
The user field will only be displayed if there is at least some ID value.

Screenshot 2025-03-21 at 18 26 20

Copy link

@nazarewk nazarewk Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, @heisbrot can you review and merge this?

</div>
</ActiveInactiveRow>
</div>
Expand Down