Add custom dns domain #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixmal
approved these changes
Apr 28, 2025
| if (customDNSDomain == "") return ""; | ||
| const valid = validator.isValidDomain(customDNSDomain, { | ||
| allowWildcard: false, | ||
| allowOnlyTld: false, |
Contributor
There was a problem hiding this comment.
Suggested change
| allowOnlyTld: false, | |
| allowOnlyTld: true, |
This should be allowed, no? E.g. if someone wants peer1.netbird or something like that
There was a problem hiding this comment.
@heisbrot This ^^. Why not allow TLD-only custom domains?
Contributor
Author
There was a problem hiding this comment.
@alindt Currently, that's a backend limitation. We will fix it once the backend is ready.
alindt
pushed a commit
to alindt/netbird-dashboard
that referenced
this pull request
Apr 29, 2025
* Update domain validator * Add custom dns domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.