move group membership from the settings menu, into the Team menu #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR moves group membership functionality from the settings menu into the Team menu, creating a dedicated groups management interface. The change improves user experience by consolidating team-related features in one location.
- Relocated group management from settings to team navigation
- Added new dedicated groups pages with detailed group views
- Enhanced group action capabilities with rename and delete functionality
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/settings/GroupsSettings.tsx | New component extracted from GroupsTab for settings-specific group configuration |
| src/modules/settings/GroupsActionCell.tsx | Removed - functionality moved to groups module |
| src/modules/groups/GroupsTable.tsx | Updated imports to reference moved components |
| src/modules/groups/GroupsTab.tsx | Updated import path for relocated GroupsTable |
| src/modules/groups/GroupsNameCell.tsx | Added navigation functionality to group names |
| src/modules/groups/GroupsActionCell.tsx | Enhanced version with dropdown menu and rename functionality |
| src/layouts/Navigation.tsx | Added Groups link to Team menu |
| src/app/(dashboard)/team/groups/page.tsx | New dedicated groups page under team section |
| src/app/(dashboard)/team/groups/layout.tsx | Layout configuration for groups page |
| src/app/(dashboard)/settings/page.tsx | Updated to use new GroupsSettings component |
| src/app/(dashboard)/group/page.tsx | New detailed group view page |
| src/app/(dashboard)/group/layout.tsx | Layout configuration for individual group pages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# Conflicts: # src/components/ui/GroupBadgeIcon.tsx # src/modules/access-control/table/AccessControlTable.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2025-10-08.19-19-32.webm
Group action: add peer or users to group
Screencast.from.2025-10-13.22-56-18.webm