-
Notifications
You must be signed in to change notification settings - Fork 89
Sync cloud changes #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync cloud changes #495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR synchronizes cloud changes to the codebase, focusing on enhancements to remote access features (SSH and RDP), UI improvements, and configuration updates. The changes include refactoring input handling for RDP connections, improving SSH access management with a new instructions modal, and making the WASM path configurable.
Key changes:
- Refactored RDP input handling by extracting logic into a new
useIronRDPInputHandlerhook - Enhanced SSH access workflow with a dedicated instructions modal and improved toggle functionality
- Made WASM path configurable through environment variables and configuration
Reviewed Changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/config.ts |
Added configurable wasmPath field to application config |
src/modules/setup-netbird-modal/WindowsTab.tsx |
Added architecture selector dropdown for Windows installer downloads |
src/modules/setup-netbird-modal/MacOSTab.tsx |
Swapped primary/secondary button positions for macOS downloads |
src/modules/remote-access/useNetBirdClient.ts |
Removed unused input handler reference and updated SSH port configuration |
src/modules/remote-access/ssh/useSSH.ts |
Added OIDC access token support for SSH connections |
src/modules/remote-access/ssh/SSHTooltip.tsx |
Refactored tooltip to show contextual messages based on peer state |
src/modules/remote-access/ssh/SSHButton.tsx |
Updated to pass peer state information to tooltip |
src/modules/remote-access/rdp/useRemoteDesktop.ts |
Integrated new input handler hook and added domain support |
src/modules/remote-access/rdp/useIronRDPInputHandler.ts |
New file implementing comprehensive RDP input handling logic |
src/modules/remote-access/rdp/ironrdp-wasm-bridge.ts |
Removed deprecated input handler attachment and improved error formatting |
src/modules/remote-access/rdp/RDPCredentialsModal.tsx |
Added domain parsing support for Windows domain accounts |
src/modules/peers/PeersTable.tsx |
Enhanced browser peer detection to include kernel version check |
src/modules/peers/PeerVersionCell.tsx |
Removed hardcoded "Web Client" label display |
src/modules/peers/PeerConnectButton.tsx |
Import order reorganization |
src/modules/peers/PeerActionCell.tsx |
Updated SSH toggle to use new instructions modal workflow |
src/modules/peer/PeerSSHToggle.tsx |
New component for SSH access toggle in peer detail view |
src/modules/peer/PeerSSHInstructions.tsx |
New modal component with step-by-step SSH enablement instructions |
src/modules/networks/table/NetworkNameCell.tsx |
Increased max width for better network name display |
src/modules/networks/misc/NetworkInformationSquare.tsx |
Changed layout from flex-wrap to flex-col for better alignment |
src/modules/networks/NetworkProvider.tsx |
Made deleteNetwork return a promise and added network-specific cache invalidation |
src/modules/access-control/useAccessControl.ts |
Fixed policy direction logic for peer destinations |
src/modules/access-control/AccessControlModal.tsx |
Disabled resource counter display for source groups |
src/contexts/PeerProvider.tsx |
Refactored SSH dialog into instructions modal with improved state management |
src/components/ui/PolicyDirection.tsx |
Fixed direction badge logic to distinguish network resources from peers |
src/components/PeerGroupSelector.tsx |
Removed redundant showResources condition check |
src/app/(remote-access)/peer/ssh/page.tsx |
Updated to use version-aware SSH port selection |
src/app/(remote-access)/peer/rdp/page.tsx |
Added domain parameter support for RDP connections |
src/app/(dashboard)/peer/page.tsx |
Integrated new SSH toggle component and removed inline implementation |
src/app/(dashboard)/network/page.tsx |
Added dropdown menu for network actions (rename, delete) |
docker/init_react_envs.sh |
Added NETBIRD_WASM_PATH environment variable configuration |
config.json |
Added wasmPath configuration field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.