[management] Add correlated network traffic event schema #3680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bcmmbaga <[email protected]>
Signed-off-by: bcmmbaga <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- management/server/http/api/openapi.yml: Language not supported
Comments suppressed due to low confidence (2)
management/server/http/api/types.gen.go:875
- Removing the main Timestamp field may cause issues if the top-level event time is needed for logging or processing. Verify that relying solely on sub-event timestamps provides sufficient context for event tracking.
- // Timestamp Timestamp of the event. Send by the peer.
management/server/http/api/types.gen.go:889
- [nitpick] The field name 'Type' in NetworkTrafficICMP could be ambiguous; consider renaming it to 'ICMPType' to improve clarity.
+ // Type ICMP type (if applicable).
Signed-off-by: bcmmbaga <[email protected]>
Updated MySQL and PostgreSQL test container functions to return the DSN string instead of setting environment variables Signed-off-by: bcmmbaga <[email protected]>
bcmmbaga
force-pushed
the
flow-events-correlation
branch
2 times, most recently
from
0fb011c to
33aa6c4
Compare
Signed-off-by: bcmmbaga <[email protected]>
bcmmbaga
force-pushed
the
flow-events-correlation
branch
from
33aa6c4 to
1dbca5a
Compare
Signed-off-by: bcmmbaga <[email protected]>
Signed-off-by: bcmmbaga <[email protected]>
Signed-off-by: bcmmbaga <[email protected]>
# Conflicts: # management/server/http/api/openapi.yml
Signed-off-by: bcmmbaga <[email protected]>
|
pascal-fischer
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist