Skip to content

Conversation

@pascal-fischer
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copilot AI review requested due to automatic review settings April 30, 2025 14:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the startup period of the peer update process configurable and updates the environment variable names accordingly.

  • Renamed the environment variable from PEER_UPDATE_INTERVAL_MS to NB_PEER_UPDATE_INTERVAL_MS.
  • Introduced a new configurable startup delay via NB_PEER_UPDATE_STARTUP_PERIOD_S instead of a fixed 30-second wait.
Comments suppressed due to low confidence (1)

management/server/account.go:213

  • The computed variable 'initialInterval' is never used; consider using 'initialInterval' for storing the buffer interval or removing it if not needed, to avoid potential confusion about the intended interval value.
am.updateAccountPeersBufferInterval.Store(int64(time.Duration(interval) * time.Millisecond))

@sonarqubecloud
Copy link

Copy link
Contributor

@crn4 crn4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascal-fischer pascal-fischer merged commit f1de8e6 into main May 16, 2025
35 checks passed
@pascal-fischer pascal-fischer deleted the feature/startup-configurable branch May 16, 2025 11:16
ntk148v pushed a commit to ntk148v/netbird that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants