Skip to content

Conversation

@lixmal
Copy link
Collaborator

@lixmal lixmal commented Apr 30, 2025

Describe your changes

with upload:
image
image

without:
image

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copilot AI review requested due to automatic review settings April 30, 2025 20:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the NetBird UI by adding a debug upload option. Key changes include introducing a default bundle URL in the upload-server, implementing a new debug window with options to anonymize, include system information, and control debug bundle upload, and updating the CLI flags and service client initialization to incorporate the debug UI.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
upload-server/types/upload.go Added a new constant (DefaultBundleURL) to define the debug upload URL.
client/ui/debug.go Introduced the new debug window UI with options for file upload and detailed dialogs for success/failure feedback.
client/ui/client_ui.go Updated flag parsing and service client creation to include the new debug flag and proper UI routing.
client/cmd/root.go Modified the CLI flag default for the debug upload URL to use the new DefaultBundleURL.
Comments suppressed due to low confidence (1)

client/ui/debug.go:90

  • [nitpick] For consistency with similar variable names used elsewhere (e.g., uploadURL), consider renaming 'uploadUrl' to 'uploadURL'.
var uploadUrl string

@sonarqubecloud
Copy link

@lixmal lixmal merged commit 9bc7d78 into main Apr 30, 2025
31 of 32 checks passed
@lixmal lixmal deleted the ui-debug-upload branch April 30, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants