Skip to content

Conversation

@lixmal
Copy link
Collaborator

@lixmal lixmal commented May 1, 2025

Describe your changes

image
image

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copilot AI review requested due to automatic review settings May 1, 2025 18:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the NetBird UI by adding debug support for duration options and refactoring window handling for network-related views while integrating logging improvements.

  • Renames the network window variable from wRoutes to wNetworks and updates corresponding function calls.
  • Adds log file support by updating the initLogFile API and propagating the log file path to relevant service client functions.
  • Refactors error logging and context handling across UI and command modules.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
client/ui/network.go Renames window variable to improve clarity and updates UI callbacks.
client/ui/client_ui.go Introduces log file handling and updates service client initialization.
client/server/debug.go Enhances debug bundle upload logging.
client/cmd/debug.go Removes network map persistence disablement during debug bundling.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 1, 2025

@mlsmaycon mlsmaycon merged commit 01c3719 into main May 1, 2025
32 checks passed
@mlsmaycon mlsmaycon deleted the ui-debug-for branch May 1, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants