Fix/darwin dns #4265
Fix/darwin dns #4265
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if ip.IsValid() { | ||
| dnsSettings.ServerIPs = append(dnsSettings.ServerIPs, ip) | ||
| } | ||
| inServerAddressesArray = false // Stop reading after finding the first IPv4 address |
There was a problem hiding this comment.
The comment states 'Stop reading after finding the first IPv4 address' but the code should now collect all IPv4 addresses since the PR adds support for multiple DNS servers. The inServerAddressesArray = false statement should be removed to continue reading all servers.
| inServerAddressesArray = false // Stop reading after finding the first IPv4 address |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
* upstream/main: (135 commits) [signal] Fix HTTP/WebSocket proxy not using custom certificates (netbirdio#4644) [client] Fix active profile name in debug bundle (netbirdio#4689) [management] Add peer disapproval reason (netbirdio#4468) [misc] Update tag name extraction in install.sh (netbirdio#4677) [client] Clean up match domain reg entries between config changes (netbirdio#4676) [client] Delete TURNConfig section from script (netbirdio#4639) [client] Security upgrade alpine from 3.22.0 to 3.22.2 netbirdio#4618 [client] Fix status showing P2P without connection (netbirdio#4661) [client] Support BROWSER env for login (netbirdio#4654) [client] Remove rule squashing (netbirdio#4653) Handle the case when the service has already been down and the status recorder is not available (netbirdio#4652) [client] Set default wg port for new profiles (netbirdio#4651) [client] Add bind activity listener to bypass udp sockets (netbirdio#4646) [client] Fix missing flag values in profiles (netbirdio#4650) [management] feat: Basic PocketID IDP integration (netbirdio#4529) [client] Force TLS1.2 for RDP with Win11/Server2025 for CredSSP compatibility (netbirdio#4617) [misc] Add service definition for netbird-signal (netbirdio#4620) [management] pass temporary flag to validator (netbirdio#4599) [client] Explicitly disable DNSOverTLS for systemd-resolved (netbirdio#4579) [management] sync all other peers on peer add/remove (netbirdio#4614) ...
hurricanehrndz
force-pushed
the
fix/darwin-dns
branch
from
0d5b525 to
7c32f4e
Compare
|
1 participant
Describe your changes
DHCP can assign multiple DNS servers on macos, so when adding local DNS server settings all assigned servers should be added.
Issue ticket number and link
Stack
Checklist