Fix: Signal container backend port set to right value

[x-504]

Describe your changes

The backend port for the signal container was wrongly set to port 80 where the listenting port of the container is 10000 by default.

Stack

Checklist

• [x ] Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

• I added/updated documentation for this change
• [ x] Documentation is not needed for this change (explain why)

Summary by CodeRabbit

• Chores
  • Updated signal service port configuration to use environment variables for greater deployment flexibility, replacing the previously fixed port mapping.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The Signal service port mapping in the docker-compose template is changed from a hardcoded 80:80 configuration to use an environment variable ${NETBIRD_SIGNAL_PORT}, making the container port configurable. Minor whitespace edits are made in the management and coturn sections.

Changes

Cohort / File(s)	Summary
Docker Compose Configuration infrastructure_files/docker-compose.yml.tmpl	Signal service port mapping changed from fixed 80:80 to ${NETBIRD_SIGNAL_PORT}:${NETBIRD_SIGNAL_PORT} environment variable substitution; whitespace normalization in management and coturn service sections

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• Signal service connection issue - incorrect port mapping in docker-compose.yml #4762 — Addresses the same Signal service port-mapping issue by making the container port configurable through environment variables instead of hardcoding port 80

Suggested reviewers

• bcmmbaga

Poem

🐰 Hop hop, a port takes flight,
No longer bound to eighty tight,
Environment variables set it free,
Configuration wild as can be! 🐇✨

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing the signal container backend port to use the correct value (10000 instead of 80).
Description check	✅ Passed	The description covers all required template sections including a clear explanation of the bug fix, proper checklist completion, and documentation justification.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes a port configuration issue in the Signal container's Docker Compose setup. The backend port was incorrectly hardcoded to port 80, when the Signal container actually listens on port 10000 by default.

• Corrects the Signal container's port mapping to use the NETBIRD_SIGNAL_PORT environment variable for both host and container ports

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI Agents

In @infrastructure_files/docker-compose.yml.tmpl:
- Line 49: The docker compose port mapping uses $NETBIRD_SIGNAL_PORT as the
container port but the service process is configured to listen on port 80,
causing a mismatch; fix by making the host:container mapping match the process
port (e.g., change the port mapping entry from "-
$NETBIRD_SIGNAL_PORT:$NETBIRD_SIGNAL_PORT" to "- $NETBIRD_SIGNAL_PORT:80") or
alternatively change the signal service to listen on $NETBIRD_SIGNAL_PORT so
both sides use the same port; apply the same consistent change for the other
occurrences in the signal service block (the entries around 53-58).

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb4fc3 and 9e105bd.

📒 Files selected for processing (1)

• infrastructure_files/docker-compose.yml.tmpl

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Critical: Port mapping and listening port are mismatched.

Line 49 maps $NETBIRD_SIGNAL_PORT:$NETBIRD_SIGNAL_PORT (container port), but line 57 configures the signal service to listen on port 80. This mismatch will break the service—traffic sent to the container's $NETBIRD_SIGNAL_PORT won't reach the process listening on port 80.

🔎 Proposed fix

    command: [
      "--cert-file", "$NETBIRD_MGMT_API_CERT_FILE",
      "--cert-key", "$NETBIRD_MGMT_API_CERT_KEY_FILE",
      "--log-file", "console",
-      "--port", "80"
+      "--port", "$NETBIRD_SIGNAL_PORT"
    ]

Also applies to: 53-58

🤖 Prompt for AI Agents

In @infrastructure_files/docker-compose.yml.tmpl at line 49, The docker compose
port mapping uses $NETBIRD_SIGNAL_PORT as the container port but the service
process is configured to listen on port 80, causing a mismatch; fix by making
the host:container mapping match the process port (e.g., change the port mapping
entry from "- $NETBIRD_SIGNAL_PORT:$NETBIRD_SIGNAL_PORT" to "-
$NETBIRD_SIGNAL_PORT:80") or alternatively change the signal service to listen
on $NETBIRD_SIGNAL_PORT so both sides use the same port; apply the same
consistent change for the other occurrences in the signal service block (the
entries around 53-58).