Fix log line which shows empty tag name#5281
Fix log line which shows empty tag name#5281gene1wood wants to merge 1 commit intonetbirdio:mainfrom
Conversation
This changes the log output line used when downloading a release binary so that instead of showing a blank TAG_NAME it shows the VERSION. This change also changes the leading whitespace on this line from a tab to 4 spaces to match it's neighboring lines. Fixes netbirdio#5280
📝 WalkthroughWalkthroughUpdated the log message in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
The Sonar Qube issue is unrelated to this PR and relates to other aspects of |
|
It looks like the
But I don't think the test failure of |




Describe your changes
This changes the log output line used when downloading a release binary so that instead of showing a blank TAG_NAME it shows the VERSION.
This change also changes the leading whitespace on this line from a tab to 4 spaces to match it's neighboring lines.
Issue ticket number and link
Fixes #5280
Stack
Checklist
Documentation
Select exactly one:
This PR fixes a very small log display issue and so doesn't need documentation.
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__
Summary by CodeRabbit