Skip to content

Fix log line which shows empty tag name#5281

Open
gene1wood wants to merge 1 commit intonetbirdio:mainfrom
gene1wood:fix-install.sh-log-line
Open

Fix log line which shows empty tag name#5281
gene1wood wants to merge 1 commit intonetbirdio:mainfrom
gene1wood:fix-install.sh-log-line

Conversation

@gene1wood
Copy link

@gene1wood gene1wood commented Feb 9, 2026

Describe your changes

This changes the log output line used when downloading a release binary so that instead of showing a blank TAG_NAME it shows the VERSION.

This change also changes the leading whitespace on this line from a tab to 4 spaces to match it's neighboring lines.

Issue ticket number and link

Fixes #5280

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

This PR fixes a very small log display issue and so doesn't need documentation.

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Bug Fixes
    • Improved installation process messaging to display resolved version information instead of tag name, providing clearer feedback during binary installation.

This changes the log output line used when downloading a release binary so that instead of showing a blank TAG_NAME it shows the VERSION.

This change also changes the leading whitespace on this line from a tab to 4 spaces to match it's neighboring lines.

Fixes netbirdio#5280
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

Updated the log message in download_release_binary function to use the resolved VERSION variable instead of the unavailable TAG_NAME variable. The TAG_NAME was declared in a subshell scope and remained inaccessible, causing blank log output.

Changes

Cohort / File(s) Summary
Binary Installation Logging
release_files/install.sh
Modified the download_release_binary function to echo VERSION instead of TAG_NAME in the log message, fixing the blank output issue where the tag name was not being displayed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A variable lost in a subshell's deep shell,
Could not find its way out to tell—
But VERSION arrives, bright and true,
Now the tag name displays just right on cue! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a log line that shows an empty tag name by using VERSION instead of TAG_NAME.
Linked Issues check ✅ Passed The PR directly addresses issue #5280 by changing the echo statement to use VERSION instead of TAG_NAME, fixing the empty log output problem described in the issue.
Out of Scope Changes check ✅ Passed The changes are narrowly focused on fixing the log output in the download_release_binary function and adjusting whitespace formatting, both directly addressing issue #5280.
Description check ✅ Passed The pull request description follows the template structure with all required sections completed: changes described, issue referenced, checklist marked, CLA agreement confirmed, and documentation decision explained.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@gene1wood
Copy link
Author

The Sonar Qube issue is unrelated to this PR and relates to other aspects of install.sh

@gene1wood
Copy link
Author

It looks like the Linux / Management / Unit (amd64, postgres) (pull_request) is failing with the error

failed to create test store after 2 attempts: failed to create test store: Error response from daemon: No such image: mlsmaycon/warmed-mysql:8: failed to create container

But I don't think the test failure of management/server/store/sql_store_test.go relates to the change in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log line in install.sh doesn't show tag

2 participants

Comments