modif: improve error messages in mountinfo.c #6711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk3
force-pushed
the
improve-mountinfo-errors
branch
from
92dceb5 to
4b46f72
Compare
kmk3
changed the title
kmk3
force-pushed
the
improve-mountinfo-errors
branch
from
4b46f72 to
ee73708
Compare
kmk3
changed the title
kmk3
force-pushed
the
improve-mountinfo-errors
branch
from
ee73708 to
87eb450
Compare
Currently when a line from /proc/self/mountinfo is too long, firejail
exits with an unclear error message:
Error: cannot read /proc/self/mountinfo
So reword it and include the maximum line length and the offending line:
Error: /proc/self/mountinfo line is too long and may be truncated (4095 >= 4095): [...]
Improve other error messages in mountinfo.c as well.
Relates to netblue30#6450.
kmk3
force-pushed
the
improve-mountinfo-errors
branch
from
87eb450 to
aaffd2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a line from /proc/self/mountinfo is too long, firejail
exits with an unclear error message:
So reword it and include the maximum line length and the offending line:
Improve other error messages in mountinfo.c as well.
Relates to #6450.