update pull

[vampiricbunny]

made it so user can just drop new iso in the iso folder (or in folders in the iso folders

[kilo-code-bot]

CRITICAL: Logic error in conditional

This line uses iseq (is equal) with && and || operators that will create unexpected flow. If ${boot_url} is empty, iseq returns true and executes goto url_boot (infinite loop). If not empty, it falls through without doing anything.

The correct iPXE pattern for "retry if empty" is:

iseq ${boot_url} && goto url_boot ||

(The trailing || continues to the next line if the variable is NOT empty)

[kilo-code-bot]

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	1
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
menus/custom.ipxe	36	Logic error in conditional — creates infinite loop when boot_url is empty

WARNING

File	Line	Issue
menus/custom.ipxe	16	Unreachable code after unconditional goto

Positive Observations

• Well-structured Docker Compose setup with clear separation of concerns (main container + watcher sidecar)
• Excellent documentation in comments and README files
• Proper use of shell script safety flags (set -euo pipefail in bash, set -e equivalent logic in sh)
• Good error handling with fallback patterns throughout
• Read-only volume mount for ISOs prevents accidental modifications
• Clean iPXE template structure following project conventions

Files Reviewed (8 files)

• .env.example - No issues
• .gitignore - No issues
• docker-compose.yml - No issues
• docker/Dockerfile.watcher - No issues
• docker/watcher.sh - No issues
• generate-iso-menu.sh - No issues
• isos/DROP_ISOS_HERE.txt - No issues
• menus/custom.ipxe - 2 issues

---

Fix these issues in Kilo Cloud

---

_{Reviewed by claude-sonnet-4.5 · 157,221 tokens}